Skip to content

[deploy site] left sample annoucement information to guide new people…#2399

Merged
rpallavisharma merged 2 commits intoSeleniumHQ:trunkfrom
rpallavisharma:fixBanner-pal
Jul 31, 2025
Merged

[deploy site] left sample annoucement information to guide new people…#2399
rpallavisharma merged 2 commits intoSeleniumHQ:trunkfrom
rpallavisharma:fixBanner-pal

Conversation

@rpallavisharma
Copy link
Copy Markdown
Member

@rpallavisharma rpallavisharma commented Jul 31, 2025 •
edited
Loading

User description

left sample annoucement information to guide new people

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

left sample annoucement information to guide new people

Description

left sample annoucement information to guide new people…

Motivation and Context

left sample annoucement information to guide new people…

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Enhancement

Description

  • Added sample announcement banner content with guidance comment

  • Included example event announcement for Selenium Community Live

  • Provided template structure for future announcements

Diagram Walkthrough

flowchart LR
  A["Empty Banner"] --> B["Sample Content"]
  B --> C["Guidance Comment"]
  B --> D["Event Announcement"]
Loading

File Walkthrough
Relevant files
Enhancement
announcement-banner.html
Added sample announcement banner content                                 

website_and_docs/layouts/partials/announcement-banner.html

  • Added guidance comment explaining how to use announcement section
  • Included sample announcement for Selenium Community Live event
  • Added structured HTML with heading and external link
 +5/-1     

@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 31, 2025 •
edited
Loading

👷 Deploy request for selenium-dev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 4f3d50d

@rpallavisharma rpallavisharma self-assigned this Jul 31, 2025
@qodo-code-review
Copy link
Copy Markdown
Contributor

qodo-code-review Bot commented Jul 31, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 Security concerns

External link security:
The external LinkedIn link uses target='_blank' without rel='noopener noreferrer', which could potentially allow the external site to access the window.opener object and redirect the original page.

⚡ Recommended focus areas for review

Outdated Content

The announcement contains a hardcoded date (July 30th, 2025) that will become outdated. This sample content should either be removed or clearly marked as placeholder text to prevent confusion.

 
Tune in for the Selenium Community Live scheduled for July 30th, 2025. 
<a href="https://www.linkedin.com/events/seleniumcommunitylive-episode87345785775592042497/theater/" target='_blank' aria-pressed="true">Join us!</a>
External Link

The LinkedIn event link should be validated to ensure it's accessible and the target='_blank' attribute should be accompanied by rel='noopener noreferrer' for security best practices.

 
    <a href="https://www.linkedin.com/events/seleniumcommunitylive-episode87345785775592042497/theater/" target='_blank' aria-pressed="true">Join us!</a>
</h4>

@qodo-code-review
Copy link
Copy Markdown
Contributor

qodo-code-review Bot commented Jul 31, 2025 •
edited
Loading

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Remove inappropriate aria attribute

The aria-pressed attribute is inappropriate for a link element as it's designed
for toggle buttons. This creates accessibility confusion for screen readers.
Remove this attribute since it doesn't apply to anchor elements.

website_and_docs/layouts/partials/announcement-banner.html [11]

-<a href="https://www.linkedin.com/events/seleniumcommunitylive-episode87345785775592042497/theater/" target='_blank' aria-pressed="true">Join us!</a>
+<a href="https://www.linkedin.com/events/seleniumcommunitylive-episode87345785775592042497/theater/" target='_blank'>Join us!</a>
  • Apply / Chat
Suggestion importance[1-10]: 6

__

Why: The suggestion correctly identifies that the aria-pressed attribute is misused on an anchor tag, and removing it improves HTML semantics and accessibility.

Low
  • Update

@rpallavisharma rpallavisharma merged commit 26617fc into SeleniumHQ:trunk Jul 31, 2025
3 checks passed
selenium-ci added a commit that referenced this pull request Jul 31, 2025
@selenium-ci
[deploy site] left sample annoucement information to guide new people… (
01a21f4 
#2399)

* [deploy site] left sample annoucement information to guide new people, added a comment

* [deploy site] added more comment 26617fc
@rpallavisharma rpallavisharma deleted the fixBanner-pal branch August 18, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@rpallavisharma rpallavisharma

Labels

Possible security concern Review effort 2/5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rpallavisharma